Readonly or mutable engine as per user configuration by konard · Pull Request #65 · link-foundation/meta-language

konard · 2026-06-10T23:31:05Z

Summary

Implements R-1 / S-1 from the issue #47 case study: a read-only or mutable
engine selected by user configuration. Today LinkNetwork is always mutable;
this adds an enforced read-only mode that composes with existing snapshot
sharing instead of duplicating it.

Fixes #49.

What changed

AccessMode { Mutable, ReadOnly } on ParseConfiguration
(with_access_mode / access_mode). Defaults to Mutable, so existing
callers see no behavior change.
ReadOnlyNetwork — a frozen view produced by LinkNetwork::freeze() /
as_read_only(). It derefs to &LinkNetwork, exposing every non-mutating
operation (query, project, reconstruct, verify, serialize) while leaving the
&mut self mutators unreachable at compile time (there is no DerefMut).
The network is held behind an Arc, so clones share one allocation.
EngineNetwork + LinkNetwork::parse_engine() — the runtime
boundary that honours the configured access mode. Read-only parsing returns
the frozen form, and EngineNetwork::as_mutable() rejects mutation with a
clear ReadOnlyViolation diagnostic.
Snapshot interop — NetworkSnapshot::as_read_only() /
from_read_only() reuse the snapshot's Arc<LinkNetwork>, so freezing and
snapshot versioning share one allocation.

Acceptance criteria

ParseConfiguration carries an access mode; default remains Mutable.
A read-only view supports every non-mutating public operation and none of
the mutating ones (compile-time enforced via Deref-without-DerefMut).
Tests cover: freeze → query/reconstruct/verify works; mutation is
impossible (compile_fail doctest) and rejected at the engine boundary
(ReadOnlyViolation); snapshot interop; Arc sharing.
Changelog fragment added (bump: minor).

How to verify

cargo test --all-features access_mode      # unit tests
cargo test --all-features --doc access     # passing + compile_fail doctests
cargo clippy --all-targets --all-features
cargo fmt --check

Read-only usage:

use meta_language::{AccessMode, LinkNetwork, ParseConfiguration};

let configuration = ParseConfiguration::default().with_access_mode(AccessMode::ReadOnly);
let mut engine = LinkNetwork::parse_engine("alpha beta", "plain-text", configuration);

assert!(engine.is_read_only());
assert_eq!(engine.reconstruct_text(), "alpha beta"); // reads work via Deref
assert!(engine.as_mutable().is_err());               // mutation rejected

Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #49

Add an AccessMode { Mutable, ReadOnly } setting to ParseConfiguration (default Mutable, no behavior change for existing callers) and a frozen read-only engine boundary. - ReadOnlyNetwork: a compile-time read-only view that derefs to &LinkNetwork, exposing every non-mutating operation while leaving the &mut self mutators unreachable (no DerefMut). Held behind an Arc so clones share one allocation. - LinkNetwork::freeze / as_read_only produce the view; EngineNetwork and LinkNetwork::parse_engine honour the configured access mode and reject mutation at runtime with a ReadOnlyViolation diagnostic. - Snapshot interop: NetworkSnapshot::as_read_only / from_read_only reuse the snapshot's Arc<LinkNetwork>, composing with snapshot versioning instead of duplicating it. - Tests cover freeze -> query/reconstruct/verify, compile-fail mutation (doctest), runtime ReadOnlyViolation, snapshot interop, and Arc sharing. - Changelog fragment (bump: minor); README usage example.

… limit

konard · 2026-06-10T23:55:16Z

Working session summary

Working tree is clean. The implementation is complete. Here's a summary of what was done for issue #49.

Summary

Implemented R-1 / S-1 from the issue #47 case study: a read-only or mutable engine selected by user configuration. PR #65 is updated and marked ready; all CI checks pass.

Changes

src/configuration.rs — Added AccessMode { Mutable, ReadOnly } (with label/is_mutable/is_read_only) and wired it into ParseConfiguration via with_access_mode() / access_mode(). Default is Mutable, so existing callers see no behavior change.

src/access.rs (new) — The access-control boundary:

ReadOnlyNetwork — a frozen view produced by LinkNetwork::freeze() / as_read_only(). It Derefs to &LinkNetwork, exposing every non-mutating operation while leaving the &mut self mutators unreachable at compile time (no DerefMut). Held behind an Arc so clones share one allocation. Includes to_mutable / into_mutable to fork back to an editable network.
EngineNetwork + LinkNetwork::parse_engine() — the runtime boundary honouring the configured access mode. Read-only parsing returns the frozen form, and as_mutable() rejects mutation with a clear ReadOnlyViolation diagnostic.

src/snapshots.rs — NetworkSnapshot::as_read_only() / from_read_only() reuse the snapshot's Arc<LinkNetwork>, so the frozen form composes with snapshot versioning instead of duplicating it.

Tests (tests/unit/access_mode.rs, 8 tests) — cover freeze → query/reconstruct/verify, default-mutable config, Arc sharing across clones, forking back to mutable, parse_engine in both modes, runtime ReadOnlyViolation, snapshot interop, and mode round-trips. A compile_fail doctest in access.rs documents that mutation cannot compile.

Docs — README feature bullet + usage example; changelog fragment (bump: minor).

Acceptance criteria — all met

✅ ParseConfiguration carries an access mode; default Mutable
✅ Read-only view supports every non-mutating operation and none of the mutating ones (compile-time enforced)
✅ Tests cover freeze/query/reconstruct, compile-fail + runtime mutation rejection, snapshot interop
✅ Changelog fragment (bump: minor)

Note on a CI fix mid-way

The first push failed the file-size guard because parse_engine pushed src/link_network.rs to 1004 lines (limit 1000). I moved that method into the access.rs impl LinkNetwork block, bringing it back to 987 lines; the subsequent run is green.

This summary was automatically extracted from the AI working session output.

konard · 2026-06-10T23:55:24Z

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost: $4.035761

📊 Context and tokens usage:

105.1K / 1M (11%) input tokens, 30.5K / 128K (24%) output tokens

Total: (8.5K new + 92.2K cache writes + 5.3M cache reads) input tokens, 30.5K output tokens, $4.035761 cost

🤖 Models used:

Tool: Anthropic Claude Code
Requested: opus
Model: Claude Opus 4.8 (claude-opus-4-8)

📎 Log file uploaded as Gist (1911KB)

View complete solution draft log

Now working session is ended, feel free to review and add any feedback on the solution draft.

konard · 2026-06-10T23:57:31Z

🔄 Auto-restart triggered (iteration 1)

Reason: Merge conflicts detected

Starting new session to address the issues.

Auto-restart-until-mergeable mode is active. This run will stop after 5 restart iterations.

…e-49-3a3011bb1089 # Conflicts: # .gitkeep

konard · 2026-06-11T00:09:29Z

Working session summary

The merge conflicts are resolved and everything is verified clean.

Summary

The PR #65 had merge conflicts against its base branch issue-47-76af108c0f24 (not main — this PR is part of the issue #47 stack). I resolved them:

Conflicts resolved (2):

.gitkeep — a modify/delete conflict. The base branch intentionally removed this PR-creation placeholder (commit 56cd745 "chore: remove .gitkeep PR-creation placeholder"), while my branch had touched it. I honored the deletion.
src/lib.rs — auto-merged cleanly; I verified the access-module wiring (pub mod access; and the EngineNetwork, ReadOnlyNetwork, ReadOnlyViolation re-exports) survived intact.

The base branch also brought in the data-exchange format grammars work (JSON/YAML/TOML/XML/INI/protobuf/GraphQL), which merged without issue.

Verification:

cargo build --all-features ✅
cargo test --all-features — 128 passed, 0 failed, plus both access-mode doctests (including the compile_fail mutation test) ✅
cargo fmt --check ✅
cargo clippy --all-targets --all-features — clean ✅
All CI checks green: Build, Lint/Format, Code Coverage, Tests on ubuntu/macos/windows, Changelog Fragment Check, Version Modification Check (release/deploy jobs correctly skipped — they only run on the default branch).

Final PR status: mergeable: MERGEABLE, mergeStateStatus: CLEAN.

Merge commit b1419cb pushed to issue-49-3a3011bb1089. PR: #65

This summary was automatically extracted from the AI working session output.

konard · 2026-06-11T00:09:36Z

🔄 Auto-restart-until-mergeable Log (iteration 1)

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost: $0.552220

📊 Context and tokens usage:

33.2K / 1M (3%) input tokens, 4.8K / 128K (4%) output tokens

Total: (2.7K new + 20.4K cache writes + 583.3K cache reads) input tokens, 4.8K output tokens, $0.552220 cost

🤖 Models used:

Tool: Anthropic Claude Code
Requested: opus
Model: Claude Opus 4.8 (claude-opus-4-8)

📎 Log file uploaded as Gist (2442KB)

View complete solution draft log

Now working session is ended, feel free to review and add any feedback on the solution draft.

konard · 2026-06-11T00:11:59Z

🎉 Auto-merged

This pull request has been automatically merged by hive-mind.

All CI checks have passed

Auto-merged by hive-mind with --auto-merge flag

Initial commit with task details

11179cd

Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #49

konard self-assigned this Jun 10, 2026

konard changed the title ~~[WIP] Readonly or mutable engine as per user configuration~~ Readonly or mutable engine as per user configuration Jun 10, 2026

konard marked this pull request as ready for review June 10, 2026 23:40

Move parse_engine to access module to keep link_network.rs under size…

f28f613

… limit

Merge remote-tracking branch 'origin/issue-47-76af108c0f24' into issu…

b1419cb

…e-49-3a3011bb1089 # Conflicts: # .gitkeep

konard merged commit 7a134e4 into issue-47-76af108c0f24 Jun 11, 2026
13 checks passed

konard mentioned this pull request Jun 11, 2026

Automatic linking detection failed, and pull requests closed without their issue to be closed as well link-assistant/hive-mind#1895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Readonly or mutable engine as per user configuration#65

Readonly or mutable engine as per user configuration#65
konard merged 4 commits into
issue-47-76af108c0f24from
issue-49-3a3011bb1089

konard commented Jun 10, 2026 •

edited

Loading

Uh oh!

konard commented Jun 10, 2026

Uh oh!

konard commented Jun 10, 2026

Uh oh!

konard commented Jun 10, 2026

Uh oh!

konard commented Jun 11, 2026

Uh oh!

konard commented Jun 11, 2026

Uh oh!

Uh oh!

konard commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

konard commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Acceptance criteria

How to verify

Uh oh!

konard commented Jun 10, 2026

Working session summary

Summary

Changes

Acceptance criteria — all met

Note on a CI fix mid-way

Uh oh!

konard commented Jun 10, 2026

🤖 Solution Draft Log

💰 Cost: $4.035761

📊 Context and tokens usage:

🤖 Models used:

📎 Log file uploaded as Gist (1911KB)

Uh oh!

konard commented Jun 10, 2026

🔄 Auto-restart triggered (iteration 1)

Uh oh!

konard commented Jun 11, 2026

Working session summary

Summary

Uh oh!

konard commented Jun 11, 2026

🔄 Auto-restart-until-mergeable Log (iteration 1)

💰 Cost: $0.552220

📊 Context and tokens usage:

🤖 Models used:

📎 Log file uploaded as Gist (2442KB)

Uh oh!

Uh oh!

konard commented Jun 11, 2026

🎉 Auto-merged

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

konard commented Jun 10, 2026 •

edited

Loading